zed.desktop.in: Don't hardcode executable name due to binary conflicts #12951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> * There are a couple of other `zed` binaries that may be present on linux systems
([1](https://openzfs.github.io/openzfs-docs/man/v2.2/8/zed.8.html),
[2](https://zed.brimdata.io/docs/commands/zed)). If you want to rename our CLI
binary because of these issues, we suggest `zedit`, `zeditor`, or `zed-cli`.
Due to aformentioned issue don't hardcode the executable name in the .desktop file
so envsubst can change it in accordance with the distributor's requirement.
Resolves zed-industries#12290.
|
We require contributors to sign our Contributor License Agreement, and we don't have @joebonrichie on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Can’t Edit: Nvm, we don't want to pass args to TryExec |
maxdeviant
pushed a commit
that referenced
this pull request
Jun 14, 2024
Fixes a problem where the env variable was being set in the wrong spot in #12951 Release Notes: - N/A
ming900518
pushed a commit
to ming900518/zed
that referenced
this pull request
Jun 14, 2024
zed-industries#12951) > * There are a couple of other `zed` binaries that may be present on linux systems ([1](https://openzfs.github.io/openzfs-docs/man/v2.2/8/zed.8.html), [2](https://zed.brimdata.io/docs/commands/zed)). If you want to rename our CLI binary because of these issues, we suggest `zedit`, `zeditor`, or `zed-cli`. Due to aformentioned issue don't hardcode the executable name in the .desktop file so envsubst can change it in accordance with the distributor's requirement. Resolves zed-industries#12290. Release Notes: - N/A
ming900518
pushed a commit
to ming900518/zed
that referenced
this pull request
Jun 14, 2024
Fixes a problem where the env variable was being set in the wrong spot in zed-industries#12951 Release Notes: - N/A
fallenwood
pushed a commit
to fallenwood/zed
that referenced
this pull request
Jun 18, 2024
zed-industries#12951) > * There are a couple of other `zed` binaries that may be present on linux systems ([1](https://openzfs.github.io/openzfs-docs/man/v2.2/8/zed.8.html), [2](https://zed.brimdata.io/docs/commands/zed)). If you want to rename our CLI binary because of these issues, we suggest `zedit`, `zeditor`, or `zed-cli`. Due to aformentioned issue don't hardcode the executable name in the .desktop file so envsubst can change it in accordance with the distributor's requirement. Resolves zed-industries#12290. Release Notes: - N/A
fallenwood
pushed a commit
to fallenwood/zed
that referenced
this pull request
Jun 18, 2024
Fixes a problem where the env variable was being set in the wrong spot in zed-industries#12951 Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to aformentioned issue don't hardcode the executable name in the .desktop file so envsubst can change it in accordance with the distributor's requirement.
Resolves #12290.
Release Notes: