-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamicer builds #13074
Merged
Merged
Dynamicer builds #13074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mikayla <mikayla@zed.dev>
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Jun 14, 2024
maxdeviant
reviewed
Jun 14, 2024
mikayla-maki
added
status bar
Status bar editor state discovery, style, etc
run-bundling
Configures PR to run the bundle step
labels
Jun 14, 2024
mikayla-maki
removed
the
status bar
Status bar editor state discovery, style, etc
label
Jun 14, 2024
ConradIrwin
commented
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
The user has signed the Contributor License Agreement
run-bundling
Configures PR to run the bundle step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13073
Note that, contrary to the issue's text, we're still shipping a statically bundled sqlite3 after this PR. We use enough new features of sqlite, like
sqlite3_error_offset
andSTRICT
, that our minimum version (v3.38.0) is higher than is presumably accessible on Ubuntu.Release Notes: