Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamicer builds #13074

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Dynamicer builds #13074

merged 13 commits into from
Jun 21, 2024

Conversation

ConradIrwin
Copy link
Member

@ConradIrwin ConradIrwin commented Jun 14, 2024

Fixes #13073

Note that, contrary to the issue's text, we're still shipping a statically bundled sqlite3 after this PR. We use enough new features of sqlite, like sqlite3_error_offset and STRICT, that our minimum version (v3.38.0) is higher than is presumably accessible on Ubuntu.

Release Notes:

  • N/A

Co-Authored-By: Mikayla <mikayla@zed.dev>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 14, 2024
@mikayla-maki mikayla-maki marked this pull request as draft June 14, 2024 21:17
@mikayla-maki mikayla-maki added status bar Status bar editor state discovery, style, etc run-bundling Configures PR to run the bundle step labels Jun 14, 2024
@mikayla-maki mikayla-maki removed the status bar Status bar editor state discovery, style, etc label Jun 14, 2024
@mikayla-maki mikayla-maki marked this pull request as ready for review June 15, 2024 00:25
crates/sqlez/Cargo.toml Outdated Show resolved Hide resolved
crates/sqlez/src/connection.rs Outdated Show resolved Hide resolved
@mikayla-maki mikayla-maki merged commit fe7d53c into main Jun 21, 2024
11 checks passed
@mikayla-maki mikayla-maki deleted the dynamic branch June 21, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement run-bundling Configures PR to run the bundle step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linux: Using system versions of libraries
4 participants