linux: Forward ctrl-w/ctrl-e to terminal #13263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `ctrl-w` and `ctrl-e` not working in the terminal pane but
instead triggering Zed actions ("close pane" and "search project
files" respectively).
I've added both because I think they're pretty commonly used in
terminals, since they're default Emacs-style keybindings.
But I also didn't want to add more, since it's relatively easy for users
to define themselves which keybindings should be forwarded to the
terminal and which not.
All that's required is adding something like this to the keymap:
```json
{
"context": "Terminal",
"bindings": {
"ctrl-n": ["terminal::SendKeystroke", "ctrl-n"],
"ctrl-p": ["terminal::SendKeystroke", "ctrl-p"]
}
}
```
cla-bot
bot
added
the
cla-signed
mrnugget
added a commit
that referenced
this pull request
Jun 20, 2024
Follow-up to #13263 Release Notes: - N/A
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
ctrl-wandctrl-enot working in the terminal pane but instead triggering Zed actions ("close pane" and "search project files" respectively).I've added both because I think they're pretty commonly used in terminals, since they're default Emacs-style keybindings.
But I also didn't want to add more, since it's relatively easy for users to define themselves which keybindings should be forwarded to the terminal and which not.
All that's required is adding something like this to the keymap:
{ "context": "Terminal", "bindings": { "ctrl-n": ["terminal::SendKeystroke", "ctrl-n"], "ctrl-p": ["terminal::SendKeystroke", "ctrl-p"] } }cc @mikayla-maki
Release Notes: