linux: Implement local time zone support #14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Seems to still fail on Linux, but that seems unrelated? Or... could it be related? In that case I'm worried :) |
|
CI fail is unrelated, it seems like that test errors from time to time 😅 (e.g. here's a commit I found where it failed: https://github.com/zed-industries/zed/actions/runs/9937101754/job/27446694222) |
apricotbucket28
force-pushed
the
linux-localtime
branch
from
2ddd603
to
85337c6
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to remove the GPUI APIs since
chronoalready provides this functionality, and is already been used for this purpose in other parts of the code (e.g. here or here)These usages end up calling the
time_formatcrate, which takes in aUtcOffset. It's probably cleaner to rewrite the crate to take inchronotypes, but that would require rewriting most of the code there.Release Notes: