Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Vue and Svelte language servers to be the first in the list for their languages #16654

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

Follow-up of #15624

Fixes #13769
Fixes #16469

This way, those are considered "primary" and serve all LSP requests like go to definition. Before, Tailwind language server was first and returned nothing for all LSP requests.

  • Fixed Vue and Svelte languages integrations not handling LSP requests properly (#13769) (#16469)

… their languages.

This way, those are considered "primary" and serve all LSP requests like go to definition.
Before, Tailwind language server was first and returned nothing for all LSP requests.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 22, 2024
@SomeoneToIgnore SomeoneToIgnore changed the title Force Vue and Svelte language servers to be the first in the list for their languages. Force Vue and Svelte language servers to be the first in the list for their languages Aug 22, 2024
@SomeoneToIgnore SomeoneToIgnore merged commit 6b9fa68 into main Aug 22, 2024
10 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/fix-primary-language-servers branch August 22, 2024 12:36
@SomeoneToIgnore
Copy link
Contributor Author

/cherry-pick v0.149.x

@SomeoneToIgnore
Copy link
Contributor Author

/cherry-pick v0.150.x

SomeoneToIgnore added a commit that referenced this pull request Aug 22, 2024
… their languages (#16654)

Follow-up of #15624

Fixes #13769
Fixes #16469

This way, those are considered "primary" and serve all LSP requests like
go to definition. Before, Tailwind language server was first and
returned nothing for all LSP requests.

- Fixed Vue and Svelte languages integrations not handling LSP requests
properly ([#13769](#13769))
([#16469](#16469))
SomeoneToIgnore added a commit that referenced this pull request Aug 22, 2024
… their languages (#16654)

Follow-up of #15624

Fixes #13769
Fixes #16469

This way, those are considered "primary" and serve all LSP requests like
go to definition. Before, Tailwind language server was first and
returned nothing for all LSP requests.

- Fixed Vue and Svelte languages integrations not handling LSP requests
properly ([#13769](#13769))
([#16469](#16469))
@maxdeviant
Copy link
Member

/cherry-pick v0.149.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 22, 2024
… their languages (#16654)

Follow-up of #15624

Fixes #13769
Fixes #16469

This way, those are considered "primary" and serve all LSP requests like
go to definition. Before, Tailwind language server was first and
returned nothing for all LSP requests.

- Fixed Vue and Svelte languages integrations not handling LSP requests
properly ([#13769](#13769))
([#16469](#16469))
@maxdeviant
Copy link
Member

/cherry-pick v0.150.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 22, 2024
… their languages (#16654)

Follow-up of #15624

Fixes #13769
Fixes #16469

This way, those are considered "primary" and serve all LSP requests like
go to definition. Before, Tailwind language server was first and
returned nothing for all LSP requests.

- Fixed Vue and Svelte languages integrations not handling LSP requests
properly ([#13769](#13769))
([#16469](#16469))
@shishkin
Copy link

Astro has the same problem and this workaround also fixes it.

  "languages": {
    "Astro": {
      "language_servers": ["astro-language-server", "..."],
      "prettier": {
        "allowed": true
      }
    }
  }

@SomeoneToIgnore
Copy link
Contributor Author

To note, the default Zed settings also use "plugins": ["prettier-plugin-astro"] for Astro's prettier, but up to you I guess.
I have filed a PR to fix Astro too, but it's somewhat odd that we have to do this so much, we'd better find a way to ask users on which language server they consider primary.

@shishkin
Copy link

Thanks @SomeoneToIgnore , I'll try adding prettier-plugin-astro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue "Go to definition" no longer works Go to definition not working again in .svelte files
3 participants