Fix use_on_type_format setting being unused per language
#18387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, `use_on_type_format` would only have an effect when
defined on a global level in our settings.
But our default.json settings would also document that it's used in
language settings, i.e.:
```json
{
"languages": {
"C": {
"use_on_type_format": false
},
"C++": {
"use_on_type_format": false
}
}
}
```
But this did **not** work.
With the change, it now works globally and per-language.
Release Notes:
- Fixed `use_on_type_format` setting not working when defined inside
`"languages"` in the settings. This change will now change the default
behavior for C, C++, and Markdown, by turning language server's
`OnTypeFormatting` completions off by default.
Co-authored-by: Bennet <bennet@zed.dev>
cla-bot
bot
added
the
cla-signed
schpet
added a commit
to schpet/zed
that referenced
this pull request
Sep 27, 2024
…reee * origin/main: git blame gutter: Use smallest possible space (zed-industries#18145) Fix minimum gutter line number spacing (zed-industries#18021) terraform: Bump to v0.1.1 (zed-industries#18382) lsp: Do not notify all language servers on file save (zed-industries#17756) Remove leftover println statements (zed-industries#18389) Fix `use_on_type_format` setting being unused per language (zed-industries#18387) Avoid panic by only restoring workspace if UI has launched (zed-industries#18386) Fix Typo in rust language guide (zed-industries#18383) editor: Fix cursor shape not restoring when setting removed (zed-industries#18379) Avoid unwrap in file finder (zed-industries#18374)
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…tries#18387) Before this change, `use_on_type_format` would only have an effect when defined on a global level in our settings. But our default.json settings would also document that it's used in language settings, i.e.: ```json { "languages": { "C": { "use_on_type_format": false }, "C++": { "use_on_type_format": false } } } ``` But this did **not** work. With the change, it now works globally and per-language. Release Notes: - Fixed `use_on_type_format` setting not working when defined inside `"languages"` in the settings. This change will now change the default behavior for C, C++, and Markdown, by turning language server's `OnTypeFormatting` completions off by default. Co-authored-by: Bennet <bennet@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
use_on_type_formatwould only have an effect when defined on a global level in our settings.But our default.json settings would also document that it's used in language settings, i.e.:
{ "languages": { "C": { "use_on_type_format": false }, "C++": { "use_on_type_format": false } } }But this did not work.
With the change, it now works globally and per-language.
Release Notes:
use_on_type_formatsetting not working when defined inside"languages"in the settings. This change will now change the default behavior for C, C++, and Markdown, by turning language server'sOnTypeFormattingcompletions off by default.