-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf support #6748
Add protobuf support #6748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding this language! I've been meaning to do this for ages 😅.
I added a few small things, and agree with my colleagues about the alphabetizing, highlighting, and outline file. If you'd like to drop by our channels or fireside hacks I'd be happy to help build the outline file. It would be great to get this one merged in :D
e5666b0
to
4bad7b0
Compare
I've addressed most of the above comments. There are still some outstanding issues though that I'm not quite sure how to tackle.
@mikayla-maki I added an outline file with some queries that felt most relevant. Happy to pair on it sometime if you feel there's more to add. |
108430a
to
ca349a3
Compare
Thank you for this PR! :D |
Let's add a new doc entry into https://github.com/zed-industries/zed/tree/main/docs/src/languages list and merge this 🎉 |
81a9c81
to
c277e13
Compare
Added doc file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still a bit odd to have the fields as defaults, but since I have no good proposal on how to capture it, let's move on.
Thank you for taking a stab at this, now Zed repo is better highlighted.
Release Notes: