Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty tooltip on Recent Projects. #8987

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Mar 7, 2024

Release Notes:

  • Fixed empty tooltip on Recent Projects.

Before

empty-tooltip

After

output

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 7, 2024
@bennetbo
Copy link
Collaborator

bennetbo commented Mar 7, 2024

Not sure if removing the tooltips from the picker is a good idea. If the path is too long it's cut off, that's why I added the tooltip here: #7528 (comment)

@huacnlee
Copy link
Contributor Author

huacnlee commented Mar 7, 2024

I agree that, we can keep it.

@huacnlee huacnlee force-pushed the fix-recent-projects-empty-tooltip branch from e180d82 to d13de14 Compare March 7, 2024 09:40
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon, recent projects will be the most polished pair of pickers thanks to your efforts 🙂

@SomeoneToIgnore SomeoneToIgnore merged commit bc7fb9f into zed-industries:main Mar 7, 2024
8 checks passed
@SomeoneToIgnore SomeoneToIgnore self-assigned this Mar 7, 2024
@huacnlee huacnlee deleted the fix-recent-projects-empty-tooltip branch March 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants