fix for decodeDict #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while tracking down a bug in decoding of dicts, i added test cases for encode/decode of lists of dict, and dicts of list. the failing test case attempts to decode into []map[string]int
this fixes the test case that attempts to decode into []map[string]int decodeDict() was calling l.nextToken() to consume the dictEndType token, but it was already consumed by 'key := l.nextToken()' above
|
Thanks so much for finding this stuff and the excellent reports/tests/patches. |
|
Happy to help! |
|
Do you mind if I license this library under the MIT (http://opensource.org/licenses/MIT) license? If so, how would you like to be attributed in the AUTHORS? |
|
By all means. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the following structs:
I was able to encode TrackerResponse successfully, but got an error on decode. I spent some time debugging, and eventually found the bug in decodeDict().