Inferred Topics on the UI to test ML Inference in Topics #501
Conversation
- Made topics slightly larger to be easier to click the remove suggestion.
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Removed the Interests Non-Interests buttons from the front page as their function is a bit confusing. I decided to leave the code, as I think it can be useful if we ever want to work on a search filter configuration. - Changed styling for Search bar to look more in line with other input fields in Zeeguu. - Added a search bar to the searches page - Added links and a small description of how user can change what gets suggested in Home.
|
As a preparations for the new topics, we are going to remove the Non-Interests "Topics". The idea is that a user picks what they like, not what they dislike to get everything else. Especially, with the new way of labeling most articles will tend to have 1 topic at most, so there is less of a situation where I might want Culture and NOT Politics. This took us through some discussions and we ended up ending on a small text with links to describe that users can adjust their home in various ways:
I really like this design, as I think it helps to explain how the home is generated for each user while also making it look cleaner. I also added the search bar to the Search tabs:
This avoids the user having to go Searches -> Home to search something if they notice they don't have a subscription they would like to have. @mircealungu @igawaclawska You can use the preview if you want to give a try to how the home looks without the Interest / Non-Interests buttons. |
- Articles don't update on preview, after changing them.
- Using redirect will not use a cached version of the webpage.
|
I found that the To get around this I added a GET parameter that is sent to the settings so the back behaviour uses redirect rather than history. Any other ideas would be welcome! |
|
In general it’s best to use react navigation within the app, instead of
modifying the DOM directly.
I’ll look into some never react router functionalities, maybe there’s some
good candidate
https://reactrouter.com/en/main/start/overview
…On Fri, 11 Oct 2024 at 13.15, Tiago Ribeiro ***@***.***> wrote:
I found that the useHistory uses the browser cache, which is a bit
problematic in the context of updating the preferences, because the user
will go back and not see an updated feed.
To get around this I added a GET parameter that is sent to the settings so
the back behaviour uses redirect rather than history. Any other ideas would
be welcome!
—
Reply to this email directly, view it on GitHub
<#501 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OY2QCZP7C6GRIMBMKXEVTZ26XN3AVCNFSM6AAAAABNAL6LVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGE4TANRWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
We use that library to navigate, but in this case I think we do want a full re-render from the server otherwise I think we can run into the issue where we don't refresh the content due to Caching from the browser side. I think I can see why you'd want to prioritize caching if you are navigating Static pages, say we went to Wikipedia and I go somewhere and go back, there is no point in re-fetching the Page. However, in this case it's like a google search where you have changed the parameters that were used, and as such we need to get a completely new page. While we are still in the same application, the previous state is void, and we should get the server to send new information. Maybe I am wrong, but that's how I see it. If we had a state that was being tracked in between these two places, I think we could use that instead, or pass a prop that would allow that (that's another alternative), but yeah I think it's a good discussion to have. |
I think that useNavigate allows passing states as a prop (I still need to read up on it to learn how it works) The downside is - our current react-router version may not support this hook. In that case, we could consider it sometime once it is updated. |
Changed topic UI
Explanation Modal
Interest Highlighting