Redesign the core actor #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bundle streaming logic in new alm::stream_transport class - Inherit from `caf::stream_manager` directly - Remove the obsolete `stream_distribution_tree`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep #89 focused on functional changes, this is the 'first chunk' of the mixin redesign. This prepares the core actor for the next transformations by:
detail::core_policy)caf::stream_managerdirectlystream_distribution_treecore_managerand refactoringcore_stateThis refactoring phase mostly moves code around and renames some types / variables. There are changes to class hierarchies but the new code should be functionally equivalent. When keeping core_policy.cc and core_policy.hh open while reviewing the new
stream_transport, it should be straightforward to track how/where code blocks moved. Having a look at https://github.com/actor-framework/actor-framework/blob/0.17.4/libcaf_core/caf/detail/stream_distribution_tree.hpp also might be helpful, because the code from this class essentially got "inlined" into the newstream_transport.