cluster-setup: Revamp Netmap section #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
force-pushed
the
topic/awelzel/freebsd-netmap-revamp
branch
2 times, most recently
from
83856b5
to
a787b4e
Compare
|
Thanks Arne, this is great. How about two subsections fro this, one for FreeBSD, one for Linux? The way the section starts out, it sounds like it's completely about FreeBSD.
Yes, great — we should no longer add material that specifically targets the |
ckreibich
reviewed
Aug 30, 2022
ckreibich
requested changes
Aug 30, 2022
awelzel
force-pushed
the
topic/awelzel/freebsd-netmap-revamp
branch
from
a787b4e
to
8a7daf3
Compare
Done. It's still fairly FreeBSD heavy, but think this mostly comes from being much more accessible there as compared to Linux. Also not sure we should recommend netmap on Linux, so maybe that imbalance is okay. |
I'm not sure this is too verbose, but given that generally seemed one needs to find small pieces of info in various places, I'm not feeling too bad putting a few details in. This is mostly from a "running without zeekctl" perspective.
awelzel
force-pushed
the
topic/awelzel/freebsd-netmap-revamp
branch
from
8a7daf3
to
84fa052
Compare
ckreibich
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is too verbose, but given that generally seemed one
needs to find small pieces of info in various places, I'm not feeling too
bad putting a few details in.
This is mostly from a "running without zeekctl" perspective.