New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize notice framework cluster communication #214

Open
jsiwek opened this Issue Nov 15, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jsiwek
Copy link
Member

jsiwek commented Nov 15, 2018

This code seems to be a no-op since it runs on the manager and not workers, but the performance problem it intended to address is still real:

https://github.com/bro/bro/blob/3f206cb8a9d90c10f2f9824373604dc0e205956b/scripts/base/frameworks/notice/main.bro#L656-L664

May require non-trivial changes, like moving notice processing to workers, but still having a way to keep de-duplication and suppression functionality.

@jsiwek jsiwek added this to the 2.6.1 milestone Nov 15, 2018

@jsiwek jsiwek modified the milestones: 2.6.1, 2.7 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment