-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore expanding the card control hit area #44
Labels
enhancement
New feature or request
Comments
MarkPearce
changed the title
Click on a button not the icon.
Click event on entire button not only the icon.
Feb 23, 2022
I don't love that the hit area is tiny, though I think you can see why it can't be the entire black rectangle given that multiple controls can share a container. |
zeel01
changed the title
Click event on entire button not only the icon.
Explore expanding the card control hit area
Feb 23, 2022
In that case you may want to look at implementations of segmented control,
or button groups. Best practice would be to make the visible button area
active, and split the button into segments if you're grouping functions.
Segmented buttons often behave like tabs, but sounds like you want to use
it more like a split button. Offering multiple related actions.
for example:
https://polaris.shopify.com/components/actions/button-group#all-examples
https://www.lightningdesignsystem.com/components/button-groups/
https://rivet.iu.edu/components/forms/buttons-segmented/
If you're interested in accessibility the minimum hit area for mouse ui is
24x24 for wcag AA, and 44x44 for AAA
…On Thu, Feb 24, 2022 at 12:22 AM Josh Olsen ***@***.***> wrote:
I don't love that the hit area is tiny, though I think you can see why it
can't be the entire black rectangle given that multiple controls can share
a container.
—
Reply to this email directly, view it on GitHub
<#44 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVHG6RBVJH2JFJOJFM4KPDU4VT5DANCNFSM5PFVTPRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hit targets on the button should use the button div, not the icon image.
this is especially bad on the flip card split button, where the active area is one of two tiny arrows
The text was updated successfully, but these errors were encountered: