Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Make parameter opts optional again. #66

Merged
merged 1 commit into from
Jan 2, 2020
Merged

[FIX]: Make parameter opts optional again. #66

merged 1 commit into from
Jan 2, 2020

Conversation

yeldiRium
Copy link
Contributor

Hi everyone,

with the release of v1.3.0 the parameter opts became mandatory because of this block. Since it checks the original opts instead of the modified options, not passing opts breaks retry.

To commit this change I had to disable the commit hook, since the var declaration not at the top of the function goes against the linter rules, but I thought I should let you decide on how to deal with your code style.

This PR will still break your CI pipeline because of the linter, but the unit tests now pass again.

Kind regards,
yeldiR

@vercel
Copy link

vercel bot commented Jan 2, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel vercel bot requested a deployment to Preview January 2, 2020 12:32 Abandoned
@vercel
Copy link

vercel bot commented Jan 2, 2020

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `scripts` property.

Copy link

@joecohens joecohens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yeldiRium!

@lucleray lucleray merged commit 9b05890 into vercel:master Jan 2, 2020
@lucleray
Copy link
Member

lucleray commented Jan 2, 2020

Thanks for reporting and fixing @yeldiRium!

@lucleray
Copy link
Member

lucleray commented Jan 2, 2020

Release in 1.3.1.

@yeldiRium yeldiRium deleted the fix-optional-opts branch January 2, 2020 18:38
@yeldiRium
Copy link
Contributor Author

Thanks for the quick reply and release of a new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants