Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for comments in tsconfig.json #11392

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add support for comments in tsconfig.json #11392

merged 1 commit into from
Mar 27, 2020

Conversation

timneutkens
Copy link
Member

Fixes #11390

@timneutkens timneutkens mentioned this pull request Mar 27, 2020
Closed
@Timer Timer added this to the 9.3.3 milestone Mar 27, 2020
Timer
Timer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timneutkens timneutkens merged commit 8fdc13a into vercel:canary Mar 27, 2020
@timneutkens timneutkens deleted the canary branch March 27, 2020 13:23
@eps1lon eps1lon mentioned this pull request Mar 29, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2020
Merged
This was referenced Apr 22, 2020
Merged
Closed
Open
Closed
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.3
Development

Successfully merging this pull request may close these issues.

tsconfig.json can no longer contain comments
2 participants
@timneutkens @Timer