FIX deploy with-firebase-hosting

[sarovin]

I have this error with yarn deploy:

There was an unknown problem while trying to parse function triggers. Please ensure you are using Node.js v6 or greater.

@jthegedus can you test this fix?

[jthegedus]

We shouldn't need this as build-funcs will create this when run.

[sarovin]

Yes, but we must run firebase deploy in dist/functions for fix the problem. If i run yarn clean and after cd \"dist/functions\" && firebase deploy, we have an error because dist/functions not exists.

[jthegedus]

cd "dist/functions" && firebase deploy

It errors because after you cd into dist/functions firebase deploy tries to deploy a directory called dist/functions which doesn't exist from the relative directory of dist/functions .

firebase deploy knows to deploy dist/functions from https://github.com/zeit/next.js/pull/3946/files#diff-0bde36a03f5abc11a925591823b9d3c2R13

[jthegedus]

and this shouldn't be required either because https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L13 should be picked up on firebase deploy.

And moving dir might mess up the deployment step of any hosting or db parts of the deployment.

[sarovin]

I don't know why...but this doesn't work for me...

[jthegedus]

In the last update I added Firebase Deployment Hooks https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L10 and https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L15 so you shouldn't need to create any folders as they are created on the output of the build-funcs, build-app & build-public steps.

@sarovin could you please double check and post your Node version, the version of firebase-tools and the full stack trace? Cheers

[jthegedus]

@sarovin Oh, I think the issue may be because I didn't change the predeploy hooks to use npm. I use Yarn in my own personal examples and the examples here use npm.

Could you try

1. reverting your changes
2. change
   https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L10
   and
   https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L15

to use npm run instead of yarn.

3. try running it again

But also still post your Node version, firebase-tools version and the full stack trace. And are you using Yarn or npm? Because you should only use npm with this example. If you want a Yarn example then please see https://github.com/jthegedus/firebase-functions-next-example

[sarovin]

@jthegedus yes, with npm run i have the same problem.

Versions:
yarn: 1.5.1
node: 8.9.3
firebase-tools: 3.17.4

[jthegedus]

I'll see if I can reproduce this problem tonight (12hrs from now). I have not come across it with my Yarn example which would indicate it's something to do with npm and the scripts.

[jthegedus]

I just reverted your changes, updated the predeploy scripts in firebase.json to use npm run in place of yarn and it all works as expected for me (no permissions to push the fixes to your fork).

Node: 8.9.4
npm: 5.6.0
firebase-tools: 3.17.4

The deployed code does fail, but that is as expected #3886 (comment) until a new Next.js release with that fix.

Just to be clear, this example should be run with npm alone. Yarn and npm should not be mixed.

[jthegedus]

The changes as per the above comment should be made.

[sarovin]

Thanks @jthegedus. I have added you as collaborator to my fork ( if you want make changes ).

[jthegedus]

@sarovin Try running npm run deploy from the root of this project now, it should work.

Unfortunately, I've not been able to reproduce your error. I have however tested the versions 5.0.0, 5.0.1.canary.10, 5.0.1.canary.11 & 5.0.1.canary.13 releases with npm & yarn and have found that versions canary.11 onwards fix any issues regarding _ files, but again, I cannot reproduce your error.