Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle all the modules inside the app #414

Merged
merged 4 commits into from
Dec 17, 2016
Merged

Bundle all the modules inside the app #414

merged 4 commits into from
Dec 17, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Dec 17, 2016

Fixes #406

@arunoda
Remove the use of CDN and bundle everything inside the app.
08f7f10 
We still pre-build the prefetcher because it needs
different webpack config which only targets browsers
supports Service Workers.
@arunoda
Remove cdn config item.
09b3a32 
We no longer using it.
@coveralls
Copy link

Coverage Status

Coverage increased (+9.3%) to 57.11% when pulling 09b3a32 on arunoda:no-bundle into 59d514e on zeit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+9.3%) to 57.11% when pulling 09b3a32 on arunoda:no-bundle into 59d514e on zeit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+9.3%) to 57.13% when pulling 7b6f26a on arunoda:no-bundle into 59d514e on zeit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+9.3%) to 57.13% when pulling 7b6f26a on arunoda:no-bundle into 59d514e on zeit:master.

@arunoda arunoda mentioned this pull request Dec 17, 2016
Merged
nkzawa
nkzawa reviewed Dec 17, 2016
View reviewed changes
package.json
@@ -63,7 +63,6 @@
"react": "15.4.1",
"react-dom": "15.4.1",
"react-hot-loader": "3.0.0-beta.6",
"read-pkg-up": "2.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove babel-plugin-transform-remove-strict-mode too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@coveralls
Copy link

coveralls commented Dec 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+11.9%) to 59.722% when pulling 97a8142 on arunoda:no-bundle into 59d514e on zeit:master.

@nkzawa
Copy link
Contributor

nkzawa commented Dec 17, 2016

👍 👍 👍 awesome

@nkzawa nkzawa merged commit b62a0e8 into vercel:master Dec 17, 2016
@arunoda arunoda deleted the no-bundle branch December 17, 2016 10:03
@lukeed
Copy link
Contributor

lukeed commented Dec 17, 2016

Thanks for adopting this @arunoda 🙌

HaNdTriX added a commit to HaNdTriX/next.js that referenced this pull request Aug 21, 2018
@HaNdTriX
Remove babel-plugin-transform-remove-strict-mode
4cb76e6 
This plugin wasn’t in use anyway.

vercel#414
@HaNdTriX HaNdTriX mentioned this pull request Aug 21, 2018
Merged
timneutkens pushed a commit that referenced this pull request Aug 22, 2018
@HaNdTriX @timneutkens
Remove babel-plugin-transform-remove-strict-mode (#5003)
24386b9 
This plugin wasn’t in use anyway.

Related: #414

Maybe we can remove the [`"strict_mode"`](https://github.com/zeit/next.js/search?q=%27use+strict%27&type=Code) statements as well.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nkzawa nkzawa nkzawa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunoda @coveralls @nkzawa @lukeed