Upgrade react-hot-loader #4277
Merged
Upgrade react-hot-loader #4277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vercel/styled-jsx#425 Fixes vercel#4246 Fixes vercel#4273
giuseppeg
approved these changes
May 5, 2018
There was a problem hiding this comment.
lgtm
some people reported that they got this error even without fragments vercel/styled-jsx#425 (comment) Maybe you can add another component inside of hrm/style.js that doesn't use fragments and render it inside of the default exported one?
| writeFileSync(pagePath, editedContent, 'utf8') | ||
|
|
||
| // wait for 5 seconds | ||
| await waitFor(5000) |
There was a problem hiding this comment.
This could be flaky or add a unnecessary delay, maybe you can make a retry function with timeout? could be done in a separate PR
There was a problem hiding this comment.
Going to merge this now, I basically copied an existing test, we could definitely improve this 👍
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
Fixes vercel/styled-jsx#425 Fixes vercel#4246 Fixes vercel#4273
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vercel/styled-jsx#425
Fixes #4246
Fixes #4273
Also adds an integration test for updating styles