Improve with-redux example #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better that Counter behave not only `increment (add)` but also `decrement` or `reset`. * Add decrement, reset handlers and rename add handler in `components/counter.js` * Add increment, decrement, reset actions to `store.js` * Rename page component class name: Counter => Index in `pages/index.js` * Remove needless dispatch count event on getInitialProps in `pages/index.js` * Format JSX to be readable in `pages/_app.js` * Remove needless line from `components/examples.js` * Remove needless spaces in `lib/with-redux-store.js`
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
It's better that Counter behave not only `increment (add)` but also `decrement` or `reset`. * Add decrement, reset handlers and rename add handler in `components/counter.js` * Add increment, decrement, reset actions to `store.js` * Rename page component class name: Counter => Index in `pages/index.js` * Remove needless dispatch count event on getInitialProps in `pages/index.js` * Format JSX to be readable in `pages/_app.js` * Remove needless line from `components/examples.js` * Remove needless spaces in `lib/with-redux-store.js`
Rokt33r
added a commit
to Rokt33r/next.js
that referenced
this pull request
Jun 30, 2018
in flavor of vercel#4377
Rokt33r
added a commit
to Rokt33r/next.js
that referenced
this pull request
Jun 30, 2018
in flavor of vercel#4377
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's better that Counter behave not only
increment (add)but alsodecrementorreset.components/counter.jsstore.jspages/index.jspages/index.jspages/_app.jscomponents/examples.jslib/with-redux-store.jsScreenshot
After
Before