Fix Typescript HMR #4689
Merged
Fix Typescript HMR #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucleray
reviewed
Jun 28, 2018
| describe('Page Extensions', () => { | ||
| beforeAll(async () => { | ||
| context.appPort = await findPort() | ||
| context.server = await launchApp(join(__dirname, '../'), context.appPort, true) |
There was a problem hiding this comment.
launchApp does not require a third argument true
(I also saw this in other integration tests)
lucleray
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4686
Adds tests for @zeit/next-typescript so that we don't regress on this again.
I've fixed an issue in the
nextCLI too which caused lingering processes when the process gets force killed, which is what we do in the test suite, so it kept running if there was no manual quit.