Add size-limit test #5339
Merged
Add size-limit test #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
force-pushed
the
add/size-limit
branch
7 times, most recently
from
9fbfdd2
to
f36166d
Compare
HaNdTriX
force-pushed
the
add/size-limit
branch
3 times, most recently
from
fab2ca9
to
15e4c15
Compare
HaNdTriX
force-pushed
the
add/size-limit
branch
2 times, most recently
from
bd83149
to
fc88016
Compare
HaNdTriX
force-pushed
the
add/size-limit
branch
from
fc88016
to
6cbb869
Compare
timneutkens
pushed a commit
that referenced
this pull request
Dec 17, 2018
…#5857) Resolves #4055 Credit: #5095 I didn't use the ignore webpack plugin from the original PR and tested bundle size with #5339 - seems to be safe on that front. Was able to get tests to pass locally, unsure of what goes wrong in CI 🤷♂️ **Questions** 1) The initial PR didn't include changes to `next-server/lib/router` in `getRouteInfo()`. Should the same changes be made within? 2) Should we add a test for rendering a component created via `forwardRef()`? `component-with-forwardedRef`: ```javascript export default React.forwardRef((props, ref) => <span {...props} forwardedRef={ref}>This is a component with a forwarded ref</span>); ``` some test: ```javascript test('renders from forwardRef', async () => { const $ = await get$('/component-with-forwardedRef') const span = $('span') expect(span.text()).toMatch(/This is a component with a forwarded ref/) }) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test for checking the file size of each client bundle.
The size is calculated by add up html size & js size without gzip compression.
Run via:
yarn testonly --testPathPattern "size-limit"