Avoiding duplicated line on loadable options. #5722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Nov 21, 2018
| @@ -115,11 +115,10 @@ export default function dynamic (dynamicOptions: any, options: NextDynamicOption | |||
|
|
|||
| // support for disabling server side rendering, eg: dynamic(import('../hello-world'), {ssr: false}) | |||
| if (typeof loadableOptions.ssr === 'boolean') { | |||
| delete loadableOptions.ssr | |||
| if (!loadableOptions.ssr) { | |||
There was a problem hiding this comment.
If ssr: true this will break, since the line above is deleting the value
There was a problem hiding this comment.
I think we should add a test for setting ssr: true, could you create a PR for that? 🙏
|
Since the current behavior is correct as per my review I'm going to close this PR, I'd love to merge a test for |
timneutkens
pushed a commit
that referenced
this pull request
Nov 25, 2018
**What's this PR?** Based on the feedback on [this PR](#5722) @timneutkens asked me to create a test for `ssr: true` **What's it do?** - adds a test for setting `ssr: true` - /basic - adds a test for setting `ssr: true` - /production
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
delete loadableOptions.ssrwill always be executed so doing it first and then going to the "if clause".