Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with-jest-typescript example to keep babel-jest in sync with jest #5941

Merged
merged 1 commit into from
Dec 23, 2018
Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 23, 2018

This fixes the with-jest-typescript example to keep jest in sync with babel-jest (also updated to the latest of both). Having them resolve to different versions was resulting in weird errors.

When attempting to update the transform property in jest.setup.js to add babel-jest support to *.js/jsx files, it would throw:

Plugin 0 specified in "node_modules/next/babel.js" provided an invalid property of "default" (While processing preset: "node_modules/next/babel.js")

Indirectly, this will fix #5917, once the author updates jest.setup.js to have:

  transform: {
    '^.+\\.(js|tsx)?$': 'babel-jest',
  },

@timneutkens timneutkens merged commit ec33b83 into vercel:canary Dec 23, 2018
@timneutkens
Copy link
Member

Amazing 🙏

@lock lock bot locked as resolved and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't reconized import statement in with-jest-typescript example
2 participants