Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous benchmark dependency #6222

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Remove extraneous benchmark dependency #6222

merged 1 commit into from
Feb 7, 2019
+0 −14

Conversation

alexandernanberg
Copy link
Contributor

AFAIK this dependency isn't being used anywhere so it should be safe to remove it.

@timneutkens timneutkens merged commit cc0b3ef into vercel:canary Feb 7, 2019
@timneutkens
Copy link
Member

It's also not part of any of the packages so it was mostly install weight when developing on the Next.js core.

@timneutkens
Copy link
Member

Thanks 🙏

rajendraarora16 added a commit to rajendraarora16/next.js that referenced this pull request Feb 8, 2019
@rajendraarora16
Merge pull request #56 from zeit/canary
7d47cce 
Remove extraneous benchmark dependency (vercel#6222)
@alexandernanberg alexandernanberg deleted the chore/remove-benchmark-dep branch February 8, 2019 05:25
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandernanberg @timneutkens