Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development mode output improvement #6312

Merged
merged 8 commits into from
Feb 16, 2019
Merged

Development mode output improvement #6312

merged 8 commits into from
Feb 16, 2019
+208 −93

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 15, 2019

This pull request simplifies Next.js' output and correctly displays the problem to the user.

Before:
image

After:
image

And for a working app, before:
image

After:
image

Resolves #4660
Resolves #6287
Closes #6298

@Timer
Copy link
Member Author

Timer commented Feb 15, 2019

As an added bonus 🚀:

Before:

Cold boot: 14s
Warm boot: 9.6s

After:

Cold boot: 8.2s
Warm boot: 5s

dav-is
dav-is approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@dav-is dav-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@timneutkens timneutkens merged commit 56b1f81 into vercel:canary Feb 16, 2019
@timneutkens timneutkens changed the title Fix development mode output Development mode output improvement Feb 16, 2019
@Timer Timer deleted the simplified-output branch February 17, 2019 18:34
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dav-is dav-is dav-is approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Timer @timneutkens @dav-is