Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ansi-html dep #6394

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Remove ansi-html dep #6394

merged 1 commit into from
Feb 21, 2019
+5 −31

Conversation

timneutkens
Copy link
Member

It's not needed since we use react-error-overlay for webpack errors.

Timer
Timer approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@timneutkens timneutkens merged commit d14d170 into vercel:canary Feb 21, 2019
@timneutkens timneutkens deleted the fix/remove-ansi-html branch February 21, 2019 23:12
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @Timer