Add more TypeScript types #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfades
requested review from
dav-is,
ijjk,
Timer and
timneutkens
as code owners
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
lfades
changed the title
timneutkens
changed the title
timneutkens
approved these changes
Apr 22, 2019
…es-ts # Conflicts: # packages/next-server/server/render.tsx
Stats from current PRClick to expand stats
Click to expand serverless stats
|
…es-ts # Conflicts: # packages/next/pages/_document.tsx
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Timer
approved these changes
Apr 22, 2019
| warnUrl() | ||
| const pushRoute = as ? href : null | ||
| const pushRoute = as ? href : '' |
There was a problem hiding this comment.
@Timer To keep it with the same type used by href, which is always a string
| warnUrl() | ||
| const replaceRoute = as ? href : null | ||
| const replaceRoute = as ? href : '' |
There was a problem hiding this comment.
@Timer To keep it with the same type used by href, which is always a string
ijjk
approved these changes
Apr 22, 2019
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Stats from current PRClick to expand stats
Click to expand serverless stats
|
huv1k
reviewed
Apr 22, 2019
| } | ||
|
|
||
| export interface IDocumentProps extends IDocumentInitialProps { | ||
| __NEXT_DATA__: INEXTDATA |
There was a problem hiding this comment.
What is reasoning to have it uppercase?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add missing types that can be very useful for Typescript projects using Next.js and for the core too.
The types are not yet being published to NPM, that will come in another PR.