Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Detect built ins in externals" #7107

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

Timer
Copy link
Member

@Timer Timer commented Apr 22, 2019

Reverts #7083

This pull request adjusted built-ins for the server target, not serverless.

Also, it'd probably be more appropriate to make this change under the .node key, e.g.:

    node: {
      module: 'empty',
      dgram: 'empty',
      dns: 'mock',
      fs: 'empty',
      http2: 'empty',
      net: 'empty',
      tls: 'empty',
      child_process: 'empty',
    },

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js revert-7083-add-built-ins Change
Build Duration 12.1s 11.9s -285ms
node_modules Size 39.9 MB 39.9 MB -407 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.5 kB 2.5 kB
Client _app gzip Size 1.02 kB 1.02 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 639 kB 639 kB
Click to expand serverless stats
zeit/next.js canary zeit/next.js revert-7083-add-built-ins Change
Build Duration 13.9s 14.1s ⚠️ +201ms
node_modules Size 39.9 MB 39.9 MB -407 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.5 kB 2.5 kB
Client _app gzip Size 1.02 kB 1.02 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 338 kB
Serverless pages/link gzip Size 87.6 kB 87.6 kB -1 B
Serverless pages/index Size 331 kB 331 kB
Serverless pages/index gzip Size 85.7 kB 85.7 kB ⚠️ +1 B
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 85.5 kB 85.5 kB
Serverless pages/routerDirect Size 331 kB 331 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.7 kB -1 B
Serverless pages/withRouter Size 331 kB 331 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.8 kB -1 B
Build Dir Size 2.24 MB 2.24 MB

@timneutkens timneutkens merged commit 2b7ca40 into canary Apr 23, 2019
@timneutkens timneutkens deleted the revert-7083-add-built-ins branch April 23, 2019 07:09
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants