Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firefox bug in next/dynamic #7203

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@ijjk
Copy link
Member

commented Apr 30, 2019

value instanceof Promise was returning false in firefox causing dynamic components using modules to not load right.

@ijjk ijjk requested review from dav-is, lfades, Timer and timneutkens as code owners Apr 30, 2019

@github-actions

This comment has been minimized.

Copy link

commented Apr 30, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/firefox-tests Change
Build Duration 11.8s 11.2s -576ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +21 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ⚠️ +1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB ⚠️ +1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 637 kB 637 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/firefox-tests Change
Build Duration 13.8s 13.7s -73ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +21 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ⚠️ +1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB ⚠️ +1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB
Serverless pages/link gzip Size 87.5 kB 87.5 kB ⚠️ +1 B
Serverless pages/index Size 321 kB 321 kB
Serverless pages/index gzip Size 85.6 kB 85.6 kB ⚠️ +2 B
Serverless pages/_error Size 322 kB 322 kB
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +1 B
Serverless pages/routerDirect Size 321 kB 321 kB
Serverless pages/routerDirect gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Serverless pages/withRouter Size 321 kB 321 kB
Serverless pages/withRouter gzip Size 85.7 kB 85.7 kB ⚠️ +2 B
Build Dir Size 2.19 MB 2.19 MB

@ijjk ijjk referenced this pull request Apr 30, 2019

Merged

Browserstack optimisations #7201

@github-actions

This comment has been minimized.

Copy link

commented Apr 30, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/firefox-tests Change
Build Duration 12.9s 13.1s ⚠️ +225ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +21 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB ⚠️ +1 B
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB ⚠️ +1 B
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 638 kB 638 kB
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/firefox-tests Change
Build Duration 15.4s 15.8s ⚠️ +339ms
node_modules Size 39.6 MB 39.6 MB ⚠️ +21 B
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.13 kB 2.13 kB
Client _app gzip Size 919 B 919 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.39 kB 5.39 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 3.62 kB 3.62 kB
Client pages/link gzip Size 1.63 kB 1.63 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 27.9 kB 27.9 kB
Client main gzip Size 9.64 kB 9.64 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.4 kB 57.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 327 kB 327 kB
Serverless pages/link gzip Size 87.6 kB 87.6 kB -2 B
Serverless pages/index Size 321 kB 321 kB
Serverless pages/index gzip Size 85.7 kB 85.7 kB -1 B
Serverless pages/_error Size 322 kB 322 kB
Serverless pages/_error gzip Size 85.4 kB 85.4 kB -1 B
Serverless pages/routerDirect Size 322 kB 322 kB
Serverless pages/routerDirect gzip Size 85.7 kB 85.7 kB
Serverless pages/withRouter Size 322 kB 322 kB
Serverless pages/withRouter gzip Size 85.8 kB 85.8 kB -2 B
Build Dir Size 2.19 MB 2.19 MB

@ijjk ijjk merged commit 808f18c into zeit:canary Apr 30, 2019

4 of 5 checks passed

ci/circleci: test Your CircleCI tests were canceled
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 49.94%
Details
zeit.next.js #20190430.14 succeeded
Details

@ijjk ijjk deleted the ijjk:fix/firefox-tests branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.