Adds basic support for PnP #8427

arcanis · 2019-08-19T18:00:47Z

This diff ensures that the Babel plugins (at least the ones that get used by the smallest Next.js instance possible) are properly resolved.

After applying this, Yarn 2 can run yarn dev (I'm using yarn link to run my local Next.js build):

Fixes #8418

Ref babel/babel#10355 for absoluteRuntime which is currently needed in PnP mode (otherwise the transpiled packages cannot require @babel/runtime-corejs2 by themselves)

Timer

This is great, thanks!

We're about to cut 9.0.4 so we will get this in the first 9.0.5-canary.0 release for general usage/testing.

packages/next/build/babel/preset.ts

ijjk · 2019-08-20T03:32:01Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
buildDuration	25.7s	25s	-619ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +240 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
link	2.8 kB	2.8 kB	✓
link gzip	850 B	849 B	-1 B
index	2.75 kB	2.75 kB	✓
index gzip	842 B	841 B	-1 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	837 B	837 B	✓
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
buildDuration	26.6s	27.1s	⚠️ +479ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +240 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	⚠️ +1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	601 B	600 B	-1 B
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	289 B	290 B	⚠️ +1 B
Overall change			✓

Client Pages Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.3 kB	66.3 kB	-1 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	866 B	867 B	⚠️ +1 B
index.js	248 kB	248 kB	✓
index.js gzip	66.6 kB	66.6 kB	✓
link.js	255 kB	255 kB	✓
link.js gzip	68.8 kB	68.8 kB	⚠️ +1 B
routerDirect.js	248 kB	248 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	-1 B
withRouter.js	248 kB	248 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +2 B
Overall change			✓

ijjk · 2019-08-20T03:34:46Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
buildDuration	25.4s	25.8s	⚠️ +343ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +240 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
link	2.8 kB	2.8 kB	✓
link gzip	850 B	848 B	-2 B
index	2.75 kB	2.75 kB	✓
index gzip	843 B	841 B	-2 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	838 B	836 B	-2 B
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
buildDuration	27.2s	27s	-201ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +240 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles

	zeit/next.js canary	arcanis/next.js mael/pnp	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.3 kB	66.3 kB	✓
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	866 B	867 B	⚠️ +1 B
index.js	248 kB	248 kB	✓
index.js gzip	66.6 kB	66.6 kB	✓
link.js	255 kB	255 kB	✓
link.js gzip	68.8 kB	68.8 kB	✓
routerDirect.js	248 kB	248 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +1 B
withRouter.js	248 kB	248 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	✓
Overall change			✓

Adds basic support for PnP

75a8aef

arcanis requested review from ijjk, lfades, Timer and timneutkens as code owners August 19, 2019 18:00

Merge branch 'canary' into mael/pnp

8255983

Timer added this to the 9.0.5 milestone Aug 19, 2019

Timer approved these changes Aug 19, 2019

View reviewed changes

Timer added the Type: Enhancement label Aug 19, 2019

ijjk reviewed Aug 19, 2019

View reviewed changes

packages/next/build/babel/preset.ts Outdated Show resolved Hide resolved

Update preset.ts

03a43a9

Timer added the ready to land label Aug 19, 2019

Timer added 6 commits August 19, 2019 16:56

Merge branch 'canary' into mael/pnp

aecd97c

Merge branch 'canary' into mael/pnp

3cdfbd9

Merge branch 'canary' into mael/pnp

d33cb82

Merge branch 'canary' into mael/pnp

3809447

Update next-babel-loader.js

2e90a83

Merge branch 'canary' into mael/pnp

63f4343

Timer merged commit a8aa15a into vercel:canary Aug 20, 2019

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds basic support for PnP #8427

Adds basic support for PnP #8427

arcanis commented Aug 19, 2019 •

edited

Loading

Timer left a comment

ijjk commented Aug 20, 2019

ijjk commented Aug 20, 2019

Adds basic support for PnP #8427

Adds basic support for PnP #8427

Conversation

arcanis commented Aug 19, 2019 • edited Loading

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Aug 20, 2019

Stats from current PR

ijjk commented Aug 20, 2019

Stats from current PR

arcanis commented Aug 19, 2019 •

edited

Loading