Remove __NEXT_REPLACE__BUILD_ID__ workaround
#8445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need this because we don't run terser on serverless bundles. --- Closes vercel#8436
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Fetched pages
Serverless Mode (Increase detected
|
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| buildDuration | 25.9s | 26.6s | |
| nodeModulesSize | 41.2 MB | 41.2 MB | -2.88 kB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| main-HASH.js | 18.1 kB | 18.1 kB | ✓ |
| main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| Overall change | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.5 kB | 16.5 kB | ✓ |
| main-HASH.module.js gzip | 6.36 kB | 6.36 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| Overall change | ✓ |
Client Pages
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 908 B | 908 B | ✓ |
| _error.js | 12.1 kB | 12.1 kB | ✓ |
| _error.js gzip | 4.76 kB | 4.76 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.81 kB | 4.81 kB | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.49 kB | 3.49 kB | ✓ |
| routerDirect.js | 433 B | 433 B | ✓ |
| routerDirect.js gzip | 296 B | 296 B | ✓ |
| withRouter.js | 444 B | 444 B | ✓ |
| withRouter.js gzip | 294 B | 294 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 867 B | 867 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.62 kB | 8.62 kB | ✓ |
| hooks.module.js | 1.55 kB | 1.55 kB | ✓ |
| hooks.module.js gzip | 804 B | 804 B | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 8.52 kB | 8.52 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 419 B | 419 B | ✓ |
| routerDirect.module.js gzip | 294 B | 294 B | ✓ |
| withRouter.module.js | 429 B | 429 B | ✓ |
| withRouter.module.js gzip | 293 B | 293 B | ✓ |
| Overall change | ✓ |
Client Build Manifests Overall decrease ✓
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 519 B | 518 B | -1 B |
| _buildManifest.module.js gzip | 311 B | 309 B | -2 B |
| Overall change | -1 B |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | Timer/next.js remove-build-id-replace | Change | |
|---|---|---|---|
| _error.js | 248 kB | 248 kB | -8 B |
| _error.js gzip | 66.5 kB | 66.2 kB | -257 B |
| hooks.html | 3.81 kB | 3.81 kB | -3 B |
| hooks.html gzip | 979 B | 976 B | -3 B |
| index.js | 248 kB | 248 kB | |
| index.js gzip | 66.6 kB | 66.6 kB | |
| link.js | 255 kB | 256 kB | |
| link.js gzip | 68.9 kB | 68.8 kB | -77 B |
| routerDirect.js | 249 kB | 249 kB | |
| routerDirect.js gzip | 66.7 kB | 66.6 kB | -58 B |
| withRouter.js | 249 kB | 249 kB | |
| withRouter.js gzip | 66.7 kB | 66.7 kB | -98 B |
| Overall change |
ijjk
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need this because we don't run terser on serverless bundles.
On a mission to 🚮 code.
Closes #8436