Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _app files from modern build manifest #8447

Merged
merged 5 commits into from
Aug 20, 2019
Merged

Remove _app files from modern build manifest #8447

merged 5 commits into from
Aug 20, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 20, 2019

Deleting _app from the assetMap causes the modern build-manifest to not be able to de-dupe the dependencies. This fixes that and adds tests to prevent regression.

Fixes: #8434

@ijjk
Copy link
Member Author

ijjk commented Aug 20, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 25.6s 26s ⚠️ +428ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +2.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 310 B 61 B -249 B
Overall change -438 B
Fetched pages Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
link 3.74 kB 3.75 kB ⚠️ +1 B
link gzip 962 B 962 B ✓
index 3.69 kB 3.69 kB ⚠️ +1 B
index gzip 954 B 954 B ✓
withRouter 3.75 kB 3.75 kB ⚠️ +1 B
withRouter gzip 949 B 948 B -1 B
Overall change ⚠️ +3 B

Diffs

Diff for main-HASH.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for main-HASH.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _app.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _error.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for routerDirect.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
Diff for withRouter.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for _app.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _error.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for routerDirect.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
Diff for withRouter.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a,b,c,d){return {"/":[a,b],"/_error":[a,c,b],"/hooks":[a,c,b],"/index":[a,b],"/link":[a,c,d,b],"/routerDirect":[a,c,d,b],"/withRouter":[a,c,d,b]}}("static\u002Fruntime\u002Fwebpack-7928590be3ef2e55b835.module.js","static\u002Fruntime\u002Fmain-26f52093cd5cae22a02c.module.js","static\u002Fchunks\u002Fframework.cdb73e402d876d4ac87f.module.js","static\u002Fchunks\u002Fxvb0EWTgFCbGZLpP5JGgragrcE0=.2da329b7caecfd217e7f.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 27.4s 27.4s ⚠️ +76ms
nodeModulesSize 41.2 MB 41.2 MB ⚠️ +2.88 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 309 B 61 B -248 B
Overall change -438 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_error.js 248 kB 248 kB -8 B
_error.js gzip 66.5 kB 66.5 kB ⚠️ +3 B
hooks.html 3.81 kB 3.81 kB -3 B
hooks.html gzip 977 B 980 B ⚠️ +3 B
index.js 248 kB 248 kB -188 B
index.js gzip 66.6 kB 66.6 kB -22 B
link.js 256 kB 255 kB -188 B
link.js gzip 68.9 kB 68.9 kB ⚠️ +33 B
routerDirect.js 249 kB 249 kB -188 B
routerDirect.js gzip 66.8 kB 66.7 kB -120 B
withRouter.js 249 kB 249 kB -188 B
withRouter.js gzip 66.7 kB 66.7 kB ⚠️ +78 B
Overall change -763 B

@Timer Timer added this to the 9.0.5 milestone Aug 20, 2019
@Timer Timer changed the title Fix build-manifest not removing _app files for modern Remove _app files from modern build manifest Aug 20, 2019
@ijjk
Copy link
Member Author

ijjk commented Aug 20, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 24.3s 23.7s -641ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 518 B 81 B -437 B
_buildManifest.module.js gzip 309 B 61 B -248 B
Overall change -437 B
Fetched pages Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
link 3.74 kB 3.75 kB ⚠️ +5 B
link gzip 963 B 962 B -1 B
index 3.69 kB 3.69 kB ⚠️ +5 B
index gzip 955 B 954 B -1 B
withRouter 3.75 kB 3.75 kB ⚠️ +5 B
withRouter gzip 949 B 949 B ✓
Overall change ⚠️ +15 B

Diffs

Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a,b,c,d){return {"/":[a,b],"/_error":[a,c,b],"/hooks":[a,c,b],"/index":[a,b],"/link":[a,c,d,b],"/routerDirect":[a,c,d,b],"/withRouter":[a,c,d,b]}}("static\u002Fruntime\u002Fwebpack-7928590be3ef2e55b835.module.js","static\u002Fruntime\u002Fmain-26f52093cd5cae22a02c.module.js","static\u002Fchunks\u002Fframework.cdb73e402d876d4ac87f.module.js","static\u002Fchunks\u002F3GCVoBnBADBTu1KjEJByZCbkTlo=.2da329b7caecfd217e7f.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 25.4s 25.5s ⚠️ +56ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 311 B 61 B -250 B
Overall change -438 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.3 kB ⚠️ +45 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 977 B 976 B -1 B
index.js 248 kB 248 kB ⚠️ +5 B
index.js gzip 66.8 kB 66.6 kB -152 B
link.js 256 kB 256 kB ⚠️ +5 B
link.js gzip 68.8 kB 68.9 kB ⚠️ +113 B
routerDirect.js 249 kB 249 kB ⚠️ +5 B
routerDirect.js gzip 66.8 kB 66.7 kB -136 B
withRouter.js 249 kB 249 kB ⚠️ +5 B
withRouter.js gzip 66.6 kB 66.8 kB ⚠️ +136 B
Overall change ⚠️ +20 B

@ijjk
Copy link
Member Author

ijjk commented Aug 20, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 25.2s 24.7s -415ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 518 B 81 B -437 B
_buildManifest.module.js gzip 308 B 61 B -247 B
Overall change -437 B
Fetched pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
link 3.74 kB 3.74 kB ✓
link gzip 955 B 966 B ⚠️ +11 B
index 3.69 kB 3.69 kB ✓
index gzip 946 B 958 B ⚠️ +12 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 941 B 953 B ⚠️ +12 B
Overall change ✓

Diffs

Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a,b,c,d){return {"/":[a,b],"/_error":[a,c,b],"/hooks":[a,c,b],"/index":[a,b],"/link":[a,c,d,b],"/routerDirect":[a,c,d,b],"/withRouter":[a,c,d,b]}}("static\u002Fruntime\u002Fwebpack-7928590be3ef2e55b835.module.js","static\u002Fruntime\u002Fmain-26f52093cd5cae22a02c.module.js","static\u002Fchunks\u002Fframework.cdb73e402d876d4ac87f.module.js","static\u002Fchunks\u002F6uy0sYSs7TJL+LVb1VWQfH3HjOo=.2da329b7caecfd217e7f.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 27.3s 26.7s -663ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 312 B 61 B -251 B
Overall change -438 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.4 kB ⚠️ +149 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 983 B 981 B -2 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.8 kB ⚠️ +180 B
link.js 256 kB 256 kB ✓
link.js gzip 68.9 kB 68.9 kB ⚠️ +9 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.8 kB 66.9 kB ⚠️ +108 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.6 kB 66.8 kB ⚠️ +140 B
Overall change ✓

@ijjk
Copy link
Member Author

ijjk commented Aug 20, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 24.1s 24s -104ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.62 kB 6.62 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 434 B 434 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 866 B 866 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 805 B 805 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 430 B 430 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 310 B 61 B -249 B
Overall change -438 B
Fetched pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
link 3.75 kB 3.75 kB ✓
link gzip 966 B 961 B -5 B
index 3.69 kB 3.69 kB ✓
index gzip 958 B 953 B -5 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 952 B 948 B -4 B
Overall change ✓

Diffs

Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a,b,c,d){return {"/":[a,b],"/_error":[a,c,b],"/hooks":[a,c,b],"/index":[a,b],"/link":[a,c,d,b],"/routerDirect":[a,c,d,b],"/withRouter":[a,c,d,b]}}("static\u002Fruntime\u002Fwebpack-7928590be3ef2e55b835.module.js","static\u002Fruntime\u002Fmain-26f52093cd5cae22a02c.module.js","static\u002Fchunks\u002Fframework.cdb73e402d876d4ac87f.module.js","static\u002Fchunks\u002FVLegGxSdc+xs0J7ZLDspVYyR1lg=.2da329b7caecfd217e7f.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 26s 25.4s -510ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB -1 B
main-HASH.js gzip 6.63 kB 6.62 kB -1 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change -1 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB -1 B
main-HASH.module.js gzip 6.36 kB 6.36 kB -1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change -1 B
Client Pages Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ⚠️ +1 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ⚠️ +1 B
routerDirect.js 433 B 434 B ⚠️ +1 B
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ⚠️ +1 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 866 B -1 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 805 B ⚠️ +1 B
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 430 B ⚠️ +1 B
withRouter.module.js gzip 293 B 293 B ✓
Overall change ⚠️ +1 B
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 519 B 81 B -438 B
_buildManifest.module.js gzip 310 B 61 B -249 B
Overall change -438 B
Serverless bundles
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.3 kB 66.3 kB ⚠️ +17 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 982 B 983 B ⚠️ +1 B
index.js 248 kB 248 kB ✓
index.js gzip 66.5 kB 66.7 kB ⚠️ +123 B
link.js 256 kB 256 kB ✓
link.js gzip 68.9 kB 68.8 kB -49 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.9 kB 66.9 kB ⚠️ +44 B
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.8 kB 66.8 kB ⚠️ +6 B
Overall change ✓

@ijjk
Copy link
Member Author

ijjk commented Aug 20, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 22.7s 21.9s -774ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 517 B 81 B -436 B
_buildManifest.module.js gzip 308 B 61 B -247 B
Overall change -436 B
Fetched pages Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
link 3.74 kB 3.75 kB ⚠️ +7 B
link gzip 964 B 963 B -1 B
index 3.69 kB 3.69 kB ⚠️ +7 B
index gzip 955 B 955 B ✓
withRouter 3.75 kB 3.75 kB ⚠️ +7 B
withRouter gzip 950 B 950 B ✓
Overall change ⚠️ +21 B

Diffs

Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a,b,c,d){return {"/":[a,b],"/_error":[a,c,b],"/hooks":[a,c,b],"/index":[a,b],"/link":[a,c,d,b],"/routerDirect":[a,c,d,b],"/withRouter":[a,c,d,b]}}("static\u002Fruntime\u002Fwebpack-7928590be3ef2e55b835.module.js","static\u002Fruntime\u002Fmain-26f52093cd5cae22a02c.module.js","static\u002Fchunks\u002Fframework.cdb73e402d876d4ac87f.module.js","static\u002Fchunks\u002FF1m1i3psmzcOuIYYpkaFI4qodBA=.2da329b7caecfd217e7f.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
buildDuration 24.6s 23.8s -764ms
nodeModulesSize 41.2 MB 41.2 MB -5 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 908 B 908 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 867 B 867 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 516 B 81 B -435 B
_buildManifest.module.js gzip 310 B 61 B -249 B
Overall change -435 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/build-manifest_app Change
_error.js 248 kB 248 kB ⚠️ +19 B
_error.js gzip 66.2 kB 66.3 kB ⚠️ +93 B
hooks.html 3.81 kB 3.81 kB ⚠️ +8 B
hooks.html gzip 979 B 977 B -2 B
index.js 248 kB 248 kB ⚠️ +19 B
index.js gzip 66.8 kB 66.6 kB -202 B
link.js 256 kB 256 kB ⚠️ +19 B
link.js gzip 68.9 kB 68.8 kB -49 B
routerDirect.js 249 kB 249 kB ⚠️ +19 B
routerDirect.js gzip 66.7 kB 66.7 kB ⚠️ +4 B
withRouter.js 249 kB 249 kB ⚠️ +19 B
withRouter.js gzip 66.8 kB 66.9 kB ⚠️ +97 B
Overall change ⚠️ +103 B

@Timer Timer merged commit 9c8aaf9 into vercel:canary Aug 20, 2019
@ijjk ijjk deleted the fix/build-manifest_app branch August 23, 2019 15:03
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.5
Development

Successfully merging this pull request may close these issues.

Modern build manifest seems incorrect
2 participants
@ijjk @Timer