Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createNewMarket arguments #27

Closed
TvrtkoM opened this issue Mar 26, 2021 · 1 comment · Fixed by #190
Closed

createNewMarket arguments #27

TvrtkoM opened this issue Mar 26, 2021 · 1 comment · Fixed by #190

Comments

@TvrtkoM
Copy link
Contributor

TvrtkoM commented Mar 26, 2021

If createNewMarket function gets changed in future please consider using options object instead of individual arguments:

e.g. something like createNewMarket(signer, title, options) instead of createNewMarket([endless list of arguments]).

@morkeltry morkeltry reopened this May 24, 2021
@morkeltry
Copy link
Contributor

morkeltry commented May 24, 2021

This change was implemented but seems to have (24th May) been reverted somehow somewhere down the line.
Reopening issue, propose (breaking change) to change out existing createNewCategoricalMarket(signer, title,description, oracle, end, creationType, categories, callback?) for object paramaters, so that the first form will cease to work.

This issue replaced by (#81)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants