Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD] Trigger benchmarks after a specific label was set #206

Closed
sea212 opened this issue Jun 28, 2021 · 1 comment · Fixed by #207
Closed

[CICD] Trigger benchmarks after a specific label was set #206

sea212 opened this issue Jun 28, 2021 · 1 comment · Fixed by #207
Assignees
Labels
p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement

Comments

@sea212
Copy link
Member

sea212 commented Jun 28, 2021

Currently the benchmark workflow is triggered, after changes were pushed to a specific staging branch. It is desired to trigger the benchmark workflow after a label like "s:benchmark-required" was set. The label should be replaced by another label once the bot is done, for example "s:benchmark-done" or the existing "s:in-progress" or even "s:review-needed".
In addition, manually triggering the workflow and therefore the benchmark process, could be useful in certain scenarios, e.g. when a benchmark is required before a release (which should not happen if everybody follows the process appropriately).

@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement labels Jun 28, 2021
@sea212 sea212 self-assigned this Jun 28, 2021
@sea212
Copy link
Member Author

sea212 commented Jun 28, 2021

@lsaether Any preferences about the label names and what label the workflow should set after its done?
I think "s:benchmark-required" -> "s:benchmark-done" is fine for the default case.
There is another case though: When a new commit occurs during the benchmarks, the bot will stop the benchmark and not commit the changes. Make a state transition like "s:benchmark-required" -> "s:benchmark-aborted" would be useful in this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant