Decompiled ovl_Obj_Bombiwa #13
Conversation
|
|
||
| static void ObjBombiwa_InitCollision(ObjBombiwa* this, GlobalContext* globalCtx) | ||
| { | ||
| ObjBombiwa* thisLocal = this; |
There was a problem hiding this comment.
Im assuming this temp is needed to match? If it could just be pad I think it'd look cleaner, but oh well if not.
There was a problem hiding this comment.
That is required unfortunately, padding doesn't match
| 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x01, 0x01, 0x00, | ||
| 0x0037, 0x0046, 0x0000, | ||
| 0x0000, 0x0000, 0x0000 |
There was a problem hiding this comment.
I believe we want to start adding trailing commas to multi-line arrays, but confirm with roman
| if ((Flags_GetSwitch(globalCtx, this->actor.params & 0x3F) != 0)) | ||
| { | ||
| Actor_Kill(&this->actor); | ||
| return; |
There was a problem hiding this comment.
I believe you could get rid of this return and make the block below and else of the outer if
There was a problem hiding this comment.
I don't really agree with removing this return since the blocks have such wildly different sizes. I think it looks cleaner this way.
There was a problem hiding this comment.
I think its better in the sense that you can scan the code and quickly realize that it is an if else. Personally dont feel like the aesthetics of the code block sizes should matter for that
| func_80078884(NA_SE_SY_CORRECT_CHIME); | ||
| } | ||
| Actor_Kill(&this->actor); | ||
| return; |
There was a problem hiding this comment.
Will remove this return though.
Various GCC improvements
Bombiwa