d_vibration & d_vib_pattern matching #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aelire
force-pushed
the
d_vibration
branch
2 times, most recently
from
7ace65e
to
3234824
Compare
LagoLunatic
reviewed
Jul 24, 2024
Aelire
force-pushed
the
d_vibration
branch
3 times, most recently
from
b7ca28a
to
08214a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what's up with
dolzel.pchand whether the class is from this header or imported from somewhere else. I can't really find references to it anywhere elseThere seems to be only one inline method and it's not completely obvious to me what precisely it could do, so I took a guess but I kinda doubt it's correct; should I leave it empty instead (it doesn't affect matching whether it's used or not)?