Exit client empty rcv #1535
Merged
Exit client empty rcv #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a hang when the server goes away unnoticed (e.g. when it is killed).
|
yep! same exact thing. |
tlinford
approved these changes
Jun 21, 2022
|
As a sidenote, initially I wanted to do it a bit differently, by having the server react to a sigterm by instructing all clients to exit, to implement a "controlled" shutdown let's say, do you think it's worth looking into that at some point? |
|
Since we need to handle ungraceful disruptions of the communication channel anyways (and now we do on both sides), I don't see a lot of sense in handling SIGTERM on the server side different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1414
did you solve it the same way @tlinford?