Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll over logs / fix filling up /tmp with logs #1548

Merged
merged 4 commits into from
Jun 28, 2022
Merged

roll over logs / fix filling up /tmp with logs #1548

merged 4 commits into from
Jun 28, 2022

Conversation

raphCode
Copy link
Contributor

@raphCode raphCode commented Jun 27, 2022

@raphCode raphCode temporarily deployed to cachix June 27, 2022 23:08 Inactive
@raphCode raphCode temporarily deployed to cachix June 27, 2022 23:08 Inactive
@raphCode raphCode temporarily deployed to cachix June 27, 2022 23:08 Inactive
@imsnif
Copy link
Member

imsnif commented Jun 28, 2022

Cool! Honestly, I cannot imagine a scenario in which we need (or even will need) more than 100KB of logs. I think we can cap it there and delete the rest.

@raphCode raphCode temporarily deployed to cachix June 28, 2022 08:31 Inactive
@raphCode raphCode temporarily deployed to cachix June 28, 2022 08:31 Inactive
@raphCode
Copy link
Contributor Author

changed the cap, now we have max. 100 kB in a file.
In case the log just rolled over, we still have the old 100 kB log so the user can always post enough logs in an issue.

@raphCode raphCode temporarily deployed to cachix June 28, 2022 09:03 Inactive
@raphCode raphCode merged commit 7cd355e into main Jun 28, 2022
@har7an har7an deleted the rolling_log branch October 23, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging may fill up /tmp mount until all zellij instances are closed
2 participants