Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance(pty): update last render time on non-backed-up render #1610

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Jul 28, 2022

This includes two minor fixes following that changes in #1585

  1. We now make sure that when the screen thread is not backed up (i.e. there's room in its buffer to receive immediate render instructions rather than buffering them), we update the render deadline so that timed-out renders will be sent properly.
  2. That being said, we also ignore the render deadline if the screen is not backed up to prevent extraneous renders

@imsnif imsnif temporarily deployed to cachix July 28, 2022 09:51 Inactive
@imsnif imsnif temporarily deployed to cachix July 28, 2022 09:51 Inactive
@imsnif imsnif temporarily deployed to cachix July 28, 2022 09:51 Inactive
@imsnif imsnif merged commit 489439a into main Jul 28, 2022
@har7an har7an deleted the last-render-update branch October 23, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant