Add GoToTabName action to switch tab by name
#2120
Conversation
|
Hey @naosense - looks great! I haven't tested this yet (hopefully will get some time later this week) - but for now, could you add a test for this? Maybe something like this? https://github.com/zellij-org/zellij/blob/main/zellij-server/src/unit/screen_tests.rs#L511 |
|
Hey @imsnif , test case added! Please check again. |
There was a problem hiding this comment.
The code looks great - I left one minor comment.
Creating a new tab doesn't work for me though... I think this is because we need to also include the new tab layout - as in, we should probably do the whole ScreenInstruction::NewTab thing. I'm not sure this will be trivial here, so if you want to give it a try - that would be great. But I think it's also cool to not implement this flag for now. Your choice.
|
@imsnif it's weird, it works for me Can you tell me about your steps, i'll reproduce it and see what's going on |
|
My apologies @naosense - I tested it again and it works. I think I might have forgotten the flag 😅 |
…#2120) * Add `GoToTabName` action to switch tab by name * rm blank file * add --create option * format * add some doc * add test case * format * add test case * change variable name
To resolve #2099 , add new action
GoToTabNameto switch tab by name