Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page scroll #298

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Add page scroll #298

merged 6 commits into from
Apr 21, 2021

Conversation

horasal
Copy link
Contributor

@horasal horasal commented Apr 21, 2021

In scroll mode, allow 'Ctrl+F' (or PageDown) and 'Ctrl+B' (or PageUp) to scroll one page forward/backward.

This pr add two new action: PageScrollUp, PageScrollDown.
When PageScrollUp/PageScrollDown triggered, current pane will scroll up/down by pane.rows() - 1 lines.

@horasal horasal changed the title Allow scroll page Add page scroll Apr 21, 2021
@TheLostLambda
Copy link
Member

This is excellent! Adding an action, things to the default config, and tests!

It works like a charm for me and is something I'd been meaning to implement for a while now 🙂

One last thing to do though! We need to add some help text to the get_mode_info() function (used by the plugin system for the help on the status bar). I'd personally put "PGUP" and "PGDN" or some variation that's better capitalized, but you'll still be able to use 'f' and 'b' just fine, even if they aren't in the help :)

Happy to merge after we make that tweak!

@horasal
Copy link
Contributor Author

horasal commented Apr 21, 2021

Added PGUP/PGDN to get_mode_info, new help info looks like:

@TheLostLambda TheLostLambda merged commit 19fc049 into zellij-org:main Apr 21, 2021
@TheLostLambda
Copy link
Member

This looks great! Thanks a ton for adding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants