Switching Tabs if there's no pane in the direction #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalmohan
suggested changes
May 8, 2021
There was a problem hiding this comment.
Hey! Thanks for the PR. This looks good! I haven't tested it yet though; a couple of small changes before I do that.
You'll have to create a new match arm with the new Action variant in
zellij/src/common/input/handler.rs
Line 106 in 7b5e728
And check for the direction. Since we might be switching tabs if the direction is left or right, we'll have to block the input thread in those cases (using the two
command_is_executing methods) to ensure atomicity for those actions. Once these are completed, we unblock the input thread by sending the UnblockInputThread message.
We should also have tests for these changes :)
New behavior for h and l, will change tabs if there are no available panes in the direction. cargo clippy Ensuring atomicity for the MoveFocusOrTab - Blocking the input thread for the action MoveFocusOrTab - Using "unreachable" macro in match arm to make it clear that the directions Up and Down should not be used with the action MoveFocusOrTab Adding tests
dantepippi
force-pushed
the
switch-tabs-464
branch
from
6c286d3
to
62796c1
Compare
kunalmohan
approved these changes
May 10, 2021
There was a problem hiding this comment.
LGTM! @dantepippi this is a great feature with a neat implementation! Thank you for your patience!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior for Alt + 'h' and Alt + 'l': will switch tabs if there are no available panes in the direction.
Closes #464