Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure workspace: Create separate crates for client, server and utilities #515

Merged
merged 3 commits into from
May 16, 2021

Conversation

kunalmohan
Copy link
Member

  • Separates zellij into 4 crates- zellij, zellij-utils, zellij-client, zellij-server.
  • zellij-utils contains all utilities shared by the client and the server. And zellij parses the command-line arguments and calls appropriate API methods exposed by zellij-client and zellij-server.
  • Since cfg(test) is not propagated to the dependencies, zellij-client, zellij-server and zellij-utils now have a feature test which zellij enables while testing. So cfg(test) has been replaced by cfg(any(feature="test", test)) in the 3 crates.
  • Makefile.toml has been modified to skip various workspace crates so that crates are compiled parallelly as a dependency, instead of compiling each crate explicitly in a sequential manner.

@khs26
Copy link
Contributor

khs26 commented May 16, 2021

Does this change how you run zellij at all? It looks like it probably doesn't, but if it does, we should update the docs

@kunalmohan
Copy link
Member Author

Does this change how you run zellij at all?

Nope, the commands are the same. I've made a few changes so that the build is not sequential, but the user interface is same. I haven't tested the install and publish commands, but I think they should work fine. I'm hoping that @TheLostLambda will be able to point out any potential bugs from a quick review of the Makefile.toml changes.

Makefile.toml Outdated Show resolved Hide resolved
@kunalmohan kunalmohan merged commit bc408e6 into main May 16, 2021
@kunalmohan kunalmohan deleted the restructure branch May 16, 2021 20:10
kunalmohan added a commit that referenced this pull request May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants