-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Move panes directionally #762
Conversation
I've added a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks great!
I only have two comments:
- I know finding free keybindings is hard, but ctrl-f is command-completion in fish. Can we find another one?
- When we resize panes, we need to also send a message to the terminal's pty that it has been resized so that the application inside the pane knows about its new size. We do it like this:
zellij/zellij-server/src/tab.rs
Lines 789 to 793 in b94b25c
self.os_api.set_terminal_size_using_fd( *pid, pane.get_content_columns() as u16, pane.get_content_rows() as u16, );
How about |
I think |
I'm not familiar with those either I'm afraid :/ If it were me I'd try to debug and compare to main, see what they expect and what's going wrong. Also btw - be sure to test that with the ctrl-h shortcut we can still use |
Fix: #164