fix(input): properly handle bracketed paste #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we handled bracketed paste after parsing the key events from Termion. However, there were some cases in which this would cause Termion to crash (since it itself doesn't handle bracketed paste mode and would get into a wrong state).
This solves this by moving bracketed paste handling to the stdin thread rather than the input thread, detecting it and handling it before parsing the stdin buffer with termion. When in bracketed paste mode, we now send the event directly to the input thread, bypassing termion.
This also has the upside of sending the full pasted text as one message to the server, rather than one message per keystroke, which speeds up pasting considerably.