Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resize): do not ignore minimums when doing directional resizes #838

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Nov 4, 2021

The (by now not so new) resizing algorithm unfortunately ignores the minimum pane sizes. Which can sometimes cause rendering issues (eg. cursor being displayed on the pane border). This doesn't fix it 100%, but it at least fixes it for cases when we resize panes directly - which is the vast majority of cases. Otherwise it's just when resizing the whole terminal window.

@TheLostLambda - any chance you can see if I'm missing something critical? This seems good to me.

@TheLostLambda
Copy link
Member

Hey @imsnif ! This looks good to me! It doesn't touch any of the super scary code inside of the actual resize file, so it's a pretty safe looking change :)

I think this brings us to the most reasonable behavior – I really think that "fixing" this when the whole terminal window is resized isn't a problem we can solve in any useful way (until we can dynamically hide panes that are "less important" or something similar)

@imsnif
Copy link
Member Author

imsnif commented Nov 4, 2021

Cool, thanks for the second pair of eyes! I have some ideas about the resizer. Will run them by you at some point to see if they make sense.

@imsnif imsnif merged commit 23c9751 into main Nov 4, 2021
@har7an har7an deleted the fix-resize-minimums branch October 23, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants