Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compatibility): full screen scroll region #915

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Dec 1, 2021

Fixes #797

This was happening because when the scroll region is set to the full viewport, it should send lines to the scrollbuffer rather than swallowing them.

In our codebase, we treat the scroll region as an Option - and this is not entirely correct according to https://vt100.net/docs/vt510-rm/DECSTBM.html

At some point we should change the scroll region to always be there and default to the first and last line of the viewport. This is however quite a big change, so for now I solved this case with a conditional.

@imsnif imsnif merged commit 464cb6b into main Dec 1, 2021
@Lillecarl
Copy link

Good work, not that anyone's asking but I'd say this deserves a release on it's own, scrollback is quite essential 😄

@imsnif
Copy link
Member Author

imsnif commented Dec 3, 2021

Definitely planning on it for next week, sorry - I'm just quite swamped at the moment.
Now that I know what the problem is, as a temporary workaround you can do echo -e "\033[r" whenever this happens. If for some reason that doesn't work, you could also do "reset" - the latter will kill the current scrollback but at least you won't have to restart the pane.

@har7an har7an deleted the fix-full-screen-scroll-region branch October 23, 2022 15:06
@mhristache
Copy link

I am still getting this issue with zellij 0.40.1, not sure what the trigger is but I mainly get into it when using ssh sessions (zellij running on my machine from which I ssh to other machines). reset is fixing it, echo -e "\033[r" doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakey Scrolling Issue
3 participants