Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance skill attribute #7

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Enhance skill attribute #7

merged 8 commits into from
Oct 28, 2024

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Jun 5, 2022

When merged this pull request will:

  • Replace group skill attribute with character skill attribute
  • Add global skill attribute

Background:

  • There are two different skills: One for the group entity and one for the character
  • The character skill affects accuracy of the AI, whereas the group skill is unused.

@Kexanone Kexanone added the enhancement Improves an existing feature label Jun 5, 2022
@Kexanone Kexanone changed the title Apply skill attribute to SCR_AICombatComponent Add character skill attribute Jun 10, 2022
@Kexanone Kexanone added feature Adds a new feature and removed enhancement Improves an existing feature labels Jun 10, 2022
@Crowdedlight
Copy link
Contributor

Looks good!
Is the skill setting for SCR_AICombatComponentan int while for AIConfigComponenta float? I assume arbitrary scale vs. percentage?

@Kexanone
Copy link
Member Author

AIConfigComponent's skill is not an arbitrary scale. It's a float value from 0 to 1. Group prefabs have a slider for that.

@Kexanone
Copy link
Member Author

Kexanone commented Jun 12, 2022

And SCR_AICombatComponent's skill is enumerated, but accepts any integer. 100 is enumerated to CYLON, which is likely the highest setting.

@Crowdedlight
Copy link
Contributor

Crowdedlight commented Jun 12, 2022

As talked about on discord, the skill-setting for the enum is used in prefabs as combo-box and not a slider. So values between enums might not be handled properly. (good spot!)

So lets change that setting to combo-box too.

enum EAISkill
{
    NONE,
    ROOKIE    = 20,
    REGULAR    = 50,
    VETERAN    = 70,
    EXPERT     = 80,
    CYLON      = 100
};

@Kexanone
Copy link
Member Author

Also adding global settings as discussed.

@Kexanone Kexanone changed the title Add character skill attribute WIP: Enhance skill attribute Jun 12, 2022
@Crowdedlight
Copy link
Contributor

I kinda forgot about this. Is it still WIP, or ready ?

@Kexanone
Copy link
Member Author

Still WIP. I doubt skill is functional for the current AI, so there's no point in completing it at the moment.

@Kexanone Kexanone marked this pull request as draft June 19, 2023 15:51
@Kexanone Kexanone changed the title WIP: Enhance skill attribute Enhance skill attribute Oct 22, 2024
@Kexanone Kexanone marked this pull request as ready for review October 22, 2024 23:03
Copy link
Contributor

@Crowdedlight Crowdedlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have a few probably silly questions.

@Kexanone Kexanone merged commit b3fcc09 into master Oct 28, 2024
@Kexanone Kexanone deleted the improve-skill branch October 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants