Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Add scheduling #81

Merged
merged 8 commits into from
Aug 27, 2019
Merged

Add scheduling #81

merged 8 commits into from
Aug 27, 2019

Conversation

MrYawe
Copy link
Contributor

@MrYawe MrYawe commented Aug 21, 2019

No description provided.

@MrYawe MrYawe self-assigned this Aug 21, 2019
idabmat
idabmat reviewed Aug 21, 2019
View reviewed changes
lib/zenaton/engine.rb Outdated Show resolved Hide resolved
idabmat
idabmat reviewed Aug 21, 2019
View reviewed changes
lib/zenaton/client.rb Outdated Show resolved Hide resolved
@idabmat idabmat mentioned this pull request Aug 26, 2019
Closed
@MrYawe MrYawe requested a review from idabmat August 26, 2019 15:33
idabmat
idabmat reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@idabmat idabmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a couple of tests cases? At least for the happy path, maybe? If I remember correctly this gem uses VCR to capture http requests and replay them during tests.

lib/zenaton/services/graphql.rb Outdated Show resolved Hide resolved
lib/zenaton/traits/zenatonable.rb Outdated Show resolved Hide resolved
@MrYawe MrYawe requested a review from idabmat August 27, 2019 15:38
idabmat
idabmat reviewed Aug 27, 2019
View reviewed changes
spec/fixtures/vcr_cassettes/grahpql_ok.yml
http_interactions:
- request:
method: post
uri: http://localhost:2000/api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on CirleCI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because the response is registered by VCR.

@MrYawe MrYawe merged commit b855088 into master Aug 27, 2019
@MrYawe MrYawe deleted the feature/scheduling branch August 27, 2019 15:52
@idabmat idabmat mentioned this pull request Sep 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@idabmat idabmat idabmat approved these changes

@pylebecq pylebecq pylebecq approved these changes

Assignees

@MrYawe MrYawe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrYawe @pylebecq @idabmat